Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Critical Difference Diagram (CDD) visualization functionality to the BBT model, allowing users to visualize global model rankings with equivalence bars based on Bayesian Bradley-Terry comparisons.
Changes:
- Added matplotlib and networkx as dependencies for plotting functionality
- Introduced new
beta_rankingproperty to PyBBT for accessing posterior mean beta values - Added
plot_cdd_diagrammethod to PyBBT for creating CDD visualizations - Refactored interpretation column selection logic into a helper method
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added matplotlib and networkx dependencies |
| uv.lock | Updated lock file with new dependencies (networkx 3.6.1, matplotlib 3.10.7) |
| bbttest/bbt/_types.py | Added InterpretationTypes type alias for "weak"/"strong" interpretations |
| bbttest/bbt/const.py | Removed file - constant moved to alg.py |
| bbttest/bbt/alg.py | Moved UNNAMED_COLUMNS_WARNING_TEMPLATE from const.py |
| bbttest/bbt/py_bbt.py | Added beta_ranking property, plot_cdd_diagram method, and _get_interpretation_columns helper; refactored rope_comparison_control_table |
| bbttest/bbt/plots/init.py | New plots module initialization |
| bbttest/bbt/plots/_critical_difference.py | New plotting implementation with graph-based clique detection and CDD rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.